search

ninia / jep

Embed Python in Java
Other
1.31k stars 149 forks source link

Overloaded varargs #452

Closed andvazqu closed 1 year ago

andvazqu commented 1 year ago

See https://github.com/ninia/jep/issues/451

ndjensen commented 1 year ago

This looks good to me. Is it possible you could add a test to the end of test_call.py where the test fails without your fix and then passes with your fix?

bsteffensmeier commented 1 year ago

The actual change in the jep code looks good to me. One of the unit tests is failing in AppVeyor in some environments for your test:

Traceback (most recent call last): File "C:\projects\jep\src\test\python\test_overload.py", line 86, in test_varargs self.assertEqual(TestOverload.varargs(0), 'int...args') AssertionError: 'int i, String...args' != 'int...args'

I think that call is ambiguous and don't neither method seems more correct to me so in my opinion the test should pass if either method is used.

bsteffensmeier commented 1 year ago

I'll be merging this in to the dev_4.2 branch, which I have not created yet so this is waiting on me now. Thank you very much for the contribution.