search

ninja-build / ninja

a small build system with a focus on speed
https://ninja-build.org/
Apache License 2.0
11.16k stars 1.59k forks source link

Ninja does not suspend child processes on ^z #1044

Open mgorny opened 8 years ago

mgorny commented 8 years ago

When I hit ^z on a terminal running Ninja, only the Ninja process is suspended and not its children. While this may have some advantages, it is a bit unexpected and makes it hard to quickly suspend all builds e.g. when system resources are being exhausted.

nicolasdespres commented 8 years ago

Fixed by PR #744

nicolasdespres commented 8 years ago

@mgorny Could you please tell me if that works for you and if the test suite passes on your machine?

mgorny commented 8 years ago

I'll try testing it tonight. I hope I don't forget before I get home.

mgorny commented 8 years ago

@nicolasdespres, all tests pass.

nicolasdespres commented 8 years ago

Great ! thx

sbc100 commented 6 years ago

Looks like this issue can be closed now?

nicolasdespres commented 6 years ago

Yes, if #744 remains opened.