clang-tidy CI way too slow

ninja-build / ninja

a small build system with a focus on speed

https://ninja-build.org/

Apache License 2.0

10.99k stars 1.58k forks source link

clang-tidy CI way too slow #2446

Open jhasse opened 4 months ago

jhasse commented 4 months ago

Our GitHub Action that runs clang-tidy takes way too much time. Something can't be right there?

digit-google commented 3 months ago

According to https://stackoverflow.com/questions/76531831/why-is-clang-tidy-in-clangd-so-much-faster-than-run-clang-tidy-itself this is normal :-/ And the alternative is to disable checks on headers or something. Not sure what to do from there though.

jhasse commented 2 months ago

hm ... it takes about 2.5 minutes on my laptop, something seems off. We should at least separate it into its own dedicated job so that it runs in parallel.

The best solution would be to add validation nodes support to ninja_syntax.py and then add validation nodes for clang-tidy to configure.py - so that it runs alongside the build with ninja itself.