ninja-build / ninja

a small build system with a focus on speed
https://ninja-build.org/
Apache License 2.0
11.16k stars 1.59k forks source link

Install error on Mavericks with XCode 5-DP #600

Closed tal closed 11 years ago

tal commented 11 years ago

When i run ./bootstrap.py

Building ninja manually...
src/manifest_parser.cc:124:15: error: use of undeclared identifier 'atol'; did you mean 'stol'?
      depth = atol(depth_string.c_str());
              ^~~~
              stol
/Applications/Xcode5-DP.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/string:3895:20: note: 'stol' declared here
long               stol  (const string& __str, size_t* __idx = 0, int __base = 10);
                   ^
1 error generated.
Failure running: ['g++', '-Wno-deprecated', '-DNINJA_PYTHON="/usr/bin/python"', '-DNINJA_BOOTSTRAP', 'src/build.cc', 'src/build_log.cc', 'src/clean.cc', 'src/depfile_parser.cc', 'src/deps_log.cc', 'src/disk_interface.cc', 'src/edit_distance.cc', 'src/eval_env.cc', 'src/explain.cc', 'src/graph.cc', 'src/graphviz.cc', 'src/lexer.cc', 'src/line_printer.cc', 'src/manifest_parser.cc', 'src/metrics.cc', 'src/ninja.cc', 'src/state.cc', 'src/subprocess-posix.cc', 'src/util.cc', 'src/version.cc', '-o', 'ninja.bootstrap']
nico commented 11 years ago

Thanks for the report. I don't have the Xcode 5 DP command line tools installed. I attempted a blink fix – can you check if you still see this at trunk?

jtbandes commented 11 years ago

Can this get put into a release tag or something? Homebrew's ninja.rb hasn't pulled in the fix.

nico commented 11 years ago

Xcode 5 isn't released yet either, is it?

I'm guessing ninja isn't the only project with issues like this in Homebrew. Do they wait for releases for every project?

jtbandes commented 11 years ago

Nope — I added this repo's HEAD as an option to the Homebrew installer. https://github.com/mxcl/homebrew/pull/20928

nico commented 11 years ago

Sounds like the fix worked, then (?)