search

ninja-build / ninja

a small build system with a focus on speed
https://ninja-build.org/
Apache License 2.0
11.03k stars 1.59k forks source link

Remove -t msvc #735

Open sgraham opened 10 years ago

sgraham commented 10 years ago

Its functionality is (almost entirely) subsumed by deps=msvc. The only thing that it's used for is to help gyp. Gyp needs to set the environment that the compiler is run in, and this was stuffed into -t msvc out of convenience long ago.

At this point -t msvc is just confusing, and should be removed, with gyp fending for itself in some other way (perhaps by adding an env_block variable to ninja).

nico commented 9 years ago

Related thread: https://groups.google.com/forum/#!topic/ninja-build/H7lMfaEVqzc On this thread, I argue that we should remove deps=msvc instead.

nico commented 9 years ago

(but neither change is backward-compatible, so neither's likely going to happen unless we do a not-background-compat release)