Just want to clarify. Does it seem that the constructor of each dictionary class is never called? - Githubissues

ninja33 / ODH

A chrome extension to show online dictionary content.

MIT License

1.43k stars 244 forks source link

Just want to clarify. Does it seem that the constructor of each dictionary class is never called? #182

Open jimlinntu opened 3 years ago

jimlinntu commented 3 years ago

As far as I know, it seems the constructor of each dictionary class is never called.

For example, src/dict/builtin_encn_Collins.js: https://github.com/ninja33/ODH/blob/2eb60f6be384abaa50446a408d40d770ce375cad/src/dict/builtin_encn_Collins.js#L3-L7

To my best knowledge, I can only see this script evaluated where it is called by SCRIPT() without options as its argument: https://github.com/ninja33/ODH/blob/2eb60f6be384abaa50446a408d40d770ce375cad/src/bg/sandbox/sandbox.js#L33-L51