search

ninjablocks / ninja-toolbelt

Ninja Blocks CLI utility
http://www.ninjablocks.com
5 stars 3 forks source link

ninja install should not assume github #1

Open thatguydan opened 11 years ago

elliots commented 11 years ago

(unless that makes it work better for the 99.9% of the time it is github)

elliots commented 11 years ago

I think it should assume github if its not specified to be something else. so ninja install elliots/ninja-xbmc should work, but so should ninja install git://myserver.com/my-driver

thatguydan commented 11 years ago

At the moment it's github or nothing, would be good to support bitbucket etc. Agreed about the git:// too.

Ideally they will set a flag ie ninja install --github elliots/ninja-xbmc that knows how to magic it from github, vs bitbucket, etc.

We might want to save ninja install elliots/ninja-xbmc for when we have compiled bundled stuff in a different location that isn't source code manager based.

elliots commented 11 years ago

Fair enough, I just think simple-now should always beat future-powerful. In the future we could make sure our compiled stuff couldn't have a forward slash for instance... or just deprecate it and ask if we do find a github repo with that name "Did you mean github://elliots/ninja-xbmc?"

elliots commented 11 years ago

Btw "ninja://drivers/ninja-xbmc" would look cool.

timoxley commented 11 years ago

Implement bitbucket/other support only when someone asks. Easy enough to change later.