search

ninjadev64 / OpenDeck

OpenDeck is a cross-platform desktop application that provides functionality for stream controller devices.
https://discord.gg/26Nf8rHvaj
GNU General Public License v3.0
182 stars 8 forks source link

Deck Neo Support? #9

Closed snek-the-great closed 5 months ago

snek-the-great commented 7 months ago

Hi, was wondering if we could get support for the Stream Deck Neo?

ninjadev64 commented 7 months ago

Hi, looks like the device was only released a few hours ago!

To support the device, it will need to be supported by the elgato-streamdeck library that we use, so you'll have to bring it up with them.

AkechiShiro commented 6 months ago

@ninjadev64 Hm is there any way we can inspire ourself from this support in Node : https://github.com/Julusian/node-elgato-stream-deck/issues/87 ? elgato-streamdeck lib is written in Python ?

EDIT : Sorry for the ping !

ninjadev64 commented 6 months ago

Sorry, I'm not sure what you mean. elgato-streamdeck is a Rust library that I do not maintain, merely use, (I do not even own a Stream Deck,) and so any requests for changes to the library should be submitted to its maintainers (notably @TheJebForge).

AkechiShiro commented 6 months ago

How can I use the rust library fork I'm working on @ninjadev64 in order to test if I can extend the support to Deck Neo ?

ninjadev64 commented 6 months ago

@AkechiShiro I've added contributing instructions for OpenDeck to the README today, so follow those first, then change the path of the elgato-streamdeck library in src-tauri/Cargo.toml to point to your fork locally ;)

AkechiShiro commented 5 months ago

The PR in elgato-streamdeck is in draft and I did test it the support works. @ninjadev64

AkechiShiro commented 5 months ago

https://github.com/streamduck-org/elgato-streamdeck/pull/10#issuecomment-2154677103

ninjadev64 commented 5 months ago

The PR in elgato-streamdeck is in draft and I did test it the support works. @ninjadev64

Cool

AkechiShiro commented 5 months ago

The PR was merged in the lib, what is left so open deck also has support for Neo ? @ninjadev64

EDIT : A new release of the lib was made, version 0.7.0 with support for Neo.

I'm guessing bumping the Cargo.toml is enough for open deck to have the support.

ninjadev64 commented 5 months ago

EDIT : A new release of the lib was made, version 0.7.0 with support for Neo.

I'm guessing bumping the Cargo.toml is enough for open deck to have the support.

Once Axias/Guillame's PR is merged, I'll bump the version of this crate so you can use your device in OpenDeck.

AkechiShiro commented 5 months ago

I've created a PR if that can help, once you have merged the other PR, you can merge also this one https://github.com/ninjadev64/OpenDeck/pull/13

Thanks for your help !

ninjadev64 commented 5 months ago

Merged, thanks!

AkechiShiro commented 5 months ago

Thanks a lot too ! Can a new release be done for the Neo support to be packaged upstream @ninjadev64 ?

ninjadev64 commented 5 months ago

I'll be publishing a new release soon, maybe this weekend.

AkechiShiro commented 5 months ago

Hey @ninjadev64, just pinging again ! For the new release, if you have time this week-end !

ninjadev64 commented 5 months ago

Hey @AkechiShiro

I had built a release earlier today, but had forgotten to publish it. Here you go!

https://github.com/ninjadev64/OpenDeck/releases/tag/v2.0.0-beta.9