search

ninjaframework / ninja-ebean

Ebean ORM support for Ninja Framework
Apache License 2.0
10 stars 8 forks source link

Explicitly call loadFromProperties() and default DDL props to false #2

Closed metacity closed 9 years ago

metacity commented 9 years ago

Ebean 6.4.1 introduced some code that expects a non-null Properties to exists in ServerConfig. This fixes the NPE that will be thrown in the current version.

I also propose defaulting Ebean DDL related properties to false to avoid scenarios where the DDL properties are undefined in Ninja's prod mode - currently this would result in dropping and recreation of the database.

jjlauer commented 9 years ago

I like the proposed changes -- especially turning off DDL changes by default.

raphaelbauer commented 9 years ago

Very nice!

raphaelbauer commented 9 years ago

Changes have been released to Maven Central as version 1.5.1. Thanks for your contribution!