ninjaframework / ninja-ebean

Ebean ORM support for Ninja Framework
Apache License 2.0
10 stars 8 forks source link

Expose DDL Seed and Init SQL properties #3

Closed drouillard closed 8 years ago

drouillard commented 8 years ago

Ebeans now supports 2 new configuration properties that allow users to run SQL scripts before and after ddl runs.

https://github.com/ebean-orm/avaje-ebeanorm/issues/515

There is

This PR focuses on the Seed SQL functionality as I find it more useful, but the initSql functionality has been exposed and I ensured it at least is called.

The following updates have been made

jjlauer commented 8 years ago

This looks good to me.

drouillard commented 8 years ago

I missed a documentation update -

This module works with a wide range of Ebean versions. It currently uses a minimum version of ebean v3.2.5, but has also been tested with the latest versions in the 4.x series. Since this module more or less configures the ebean server, it should be compatible with any ebean release that continues to support those configuration properties.

@raphaelbauer if you are OK with the version bump I will go ahead and update this as well. I should have noted the information on updated enhancement in regards to the plugin to use comes from https://github.com/ebean-orm/avaje-ebeanorm/wiki/Enhancement

I suspect this should be a major Semver update, as if you tried to use this with a 3.x version of ebeans-orm then it would not be compatible. I could update the doc to list state that this version requires v6.16 but then also link to the tag of v1.5.1 and indicate that is can be used for older version of ebeans.

raphaelbauer commented 8 years ago

That looks nice...! @jjlauer would you mind merging this when it is ok for you?

raphaelbauer commented 8 years ago

:+1:

jjlauer commented 8 years ago

@raphaelbauer Can you push out a new release? I was thinking 1.6.0 or 2.0.0 is appropriate since the ebean dependency version bump was so large.

raphaelbauer commented 8 years ago

Just released 2.0.0...