search

ninjaframework / ninja

Ninja is a full stack web framework for Java. Rock solid, fast and super productive.
http://www.ninjaframework.org
Apache License 2.0
1.91k stars 519 forks source link

Replace java.text.MessageFormat with ICU4J equivalent #192

Open raphaelbauer opened 10 years ago

raphaelbauer commented 10 years ago

For a lot of reasons. Most importantly to get rid of the stupid '' escaping rule.

http://icu-project.org/apiref/icu4j/com/ibm/icu/text/MessageFormat.html

JuanCaicedo commented 10 years ago

I did a search for MessageFormat and only found it in FlashScope, MessagesImpl and Messages. After adding a new dependency for icu4j and switching out the MessageFormat class, everything compiles and the tests pass still. I'll submit a pull request, let me know if it works the way you're expecting!