ninjaframework / ninja

Ninja is a full stack web framework for Java. Rock solid, fast and super productive.
http://www.ninjaframework.org
Apache License 2.0
1.91k stars 518 forks source link

Is Ninja-Framework safe regarding "Critical New 0-day Vulnerability in Popular Log4j Library"? #720

Closed rrarrarra closed 2 years ago

rrarrarra commented 2 years ago

Hi,

currently there is a "Critical New 0-day Vulnerability in Popular Log4j Library".

Now my question is, if this is (or could be) a problem for applications running with the "ninja-framework Version 6.2.0"?

I am also not sure, if the ninja-framework (or some of its dependencies) uses "log4j"?

I have found, that ninja uses "log4j-over-slf4j" but I am not familiar with these libraries in detail, so, maybe some of you or the core-developers could help out here or give a small hint, if something needs to be updated or done, or if ninja-apps are safe regarding this vulnerability and nothing needs to be done.

Or how to check, if the application, that uses the ninja-framework, is "safe" regarding "Critical New 0-day Vulnerability in Popular Log4j Library"?

Many thanks and best regards

rrarrarra commented 2 years ago

There is also written, that the mitigation would be:

--> Which gave me indirectly the information, that the "vulnerability" is placed in the "org/apache/logging/log4j/core/lookup/JndiLookup.class".

Ok, this is what I have done right now to check, if my app uses "log4j" (or at least if it has included this class):

... I did not find the path "org/apache/logging/log4j" and also no class named "JndiLookup.class" in that path.

Which, indirectly should mean, that my ninja-app is not affected to this specific "security vulnerability"?

Thanks for help and best regards

rrarrarra commented 2 years ago

@raphaelbauer as the main contributor of ninjaframework, any thoughts about that issue?

thanks and best regards

jjlauer commented 2 years ago

We use Ninja extensively in our public-facing and internal apps and based on our review, we have NO log4j exposure.

However, Ninja is simply a framework and someone could go out of their way to force log4j use thru switching out of Ninja's default logback logger. So, its best to check yourself as well. However, if you're using Ninja out of the box, you should be all set.

rrarrarra commented 2 years ago

Good to hear that and thanks for your answer!

cheers