search

ninjaframework / ninja

Ninja is a full stack web framework for Java. Rock solid, fast and super productive.
http://www.ninjaframework.org
Apache License 2.0
1.91k stars 521 forks source link

Test Smell: it is not a good practice to write return statement in test case #751

Open TestSmell opened 2 years ago

TestSmell commented 2 years ago

Hi!

I notice that you write a test case with a return statement.

image

It is not a good idea to write the return statement in your test case. So I would like to know if is it really a useful test case? It also has no assertions. Maybe I think you should remove the @test annotation from this method ? Thanks.