search

ninjanye / SearchExtensions

Library of IQueryable extension methods to perform searching
MIT License
331 stars 52 forks source link

NET Core support #18

Closed maximtarasov closed 7 years ago

maximtarasov commented 7 years ago

Hi!

Your project is very useful and it will be great, if you will introduce NET Core support.

ninjanye commented 7 years ago

I completely agree. This is something I definitely want to do... Now that the holidays are over, I'll try and get this started

ninjanye commented 7 years ago

Hi @maximtarasov

I begun to look at the work involved in adding .NET Core support and based on the current .Net Standard API (1.6) a fair amount of the code is unsupported and would need to be re-written. the good news is that all the code is supported in .NET Standard 2.0 so I think I may wait until that is released before adding this.

Sorry it is going to take longer than i had first hoped

tylertyssedal commented 7 years ago

Anyone know of any alternatives for .NET Core?

I am in the middle of a migration, and trying to iron out all of the incompatibilities here... unfortunately, this is the only one that is in the way at this time.

maximtarasov commented 7 years ago

@ninjanye which components are unsupported on NET Core? Can you list them?

ninjanye commented 7 years ago

@maximtarasov I'll dig out the report. From memory it was some reflection stuff and some linq bits. I'll double check. If the changes aren't to large, I'll update.

Sorry it's taken a while to get this sorted.

ninjanye commented 7 years ago

@maximtarasov @metamet Good news, I have almost complete the port for .NET Core. I hope to get a new package out in the next few days. I'll keep you posted

ninjanye commented 7 years ago

@maximtarasov @metamet It took longer than anticipated but I have recently released an new version of Search extensions that is now entirely built on netstandard1.5

ninjanye commented 7 years ago

Resolved as part of https://github.com/ninjanye/SearchExtensions/commit/38dbff1805dfaeb73b4f9704f498dd48c758d9b6

Published to nuget (v2.1.0)