Closed hieplpvip closed 6 years ago
Does that code actually work lol?
First thing - i'm really confused whose PR this is - stek if you want to submit a PR, please create a separate PR (it says its by hieplpvip, but everything else is related to your stuff)
Second thing - I don't intend to have a method to "dynamically" add hashes to the trust chain. Main reasons being that a) you're current method stek is IMO a little bit bad since its creating a new entry every time, whereas it would be better to have one entry for multiple hashes and b) it's better if we use the trust chain to run binaries to patch amfid, so that we don't have to rely on injecting the trust cache every time
It's not by me, it's by @hieplpvip
Speaking of my current method -- I was trying to make it add structs with dynamic size or even create a struct and add hashes to it later, but failed and resorted to just adding them one by one for now, see here
And yes, it'd be better to patch amfid, I agree. But for now adding stuff manually will do.
If I was going to make a PR I'd at least Clean it up, rebase it and make a separate branch :)
Sorry about it @stek29 it does work :)
@hieplpvip sorry, I haven't noticed you've posted entirely different code in comment :}
void inject_trusts(int pathc, char *paths[]) { uint64_t tc = find_trustcache();
}