search

ninjasort / react-star-rating

[Looking for Maintainers (email me)]: A simple star rating component built with React.
MIT License
173 stars 55 forks source link

Half stars #18

Open asaf opened 8 years ago

asaf commented 8 years ago

Hey,

Why half stars are not supported any longer?

Thanks.

ninjasort commented 8 years ago

I was initially trying to port the CSS-based clipping to SVG, but saw that React didn't support the mask attribute so pulled out the half stars. I can try to put it back in with another clipPath approach and see how that goes. Otherwise, we'll need to wait until react supports the mask attribute. I'll try to get to this in v1.5

asaf commented 8 years ago

Crap :)

this is one of the nicest features of this component,

Thanks for answering!

ninjasort commented 8 years ago

It will be back soon enough. Sorry for the inconvenience.

asaf commented 8 years ago

Any ETA for this one?

asaf commented 8 years ago

Possible solution: http://codepen.io/mrk1989/pen/mLeHJ

ninjasort commented 8 years ago

Yeah, looks good. I'll try to work this in, thanks.

pkhand0 commented 7 years ago

Still it is not supporting decimal rating..

ninjasort commented 7 years ago

Hey, sorry about that. I've been super busy. I'll be refactoring a lot of this module when I get some time coming up. Hang tight!