search

ninjasort / react-star-rating

[Looking for Maintainers (email me)]: A simple star rating component built with React.
MIT License
173 stars 58 forks source link

move react-addons-test-utils to dev dependencies #26

Closed jonathanong closed 8 years ago

jonathanong commented 8 years ago

shouldn't be necessary as a depedency

jonathanong commented 8 years ago

also all the react dependencies because it makes it harder to upgrade react versions. should use a wider range

jonathanong commented 8 years ago

@cameronroe can u fix this quickly or add someone as a collab? this is blocking everyone from updating to react 15

ninjasort commented 8 years ago

Hey @jonathanong, sorry about that. I'll look at it tonight.

ninjasort commented 8 years ago

Hey man, really sorry but I don't have time to fix this right now. I'll try to get to it as soon as I can, but there's a lot that's going to change with it. Could you just fork it for now?

jonathanong commented 8 years ago

just give this guy access https://github.com/cameronroe/react-star-rating/pull/27

ninjasort commented 8 years ago

That's potentially a breaking change and will need to switch up the API being used. You're welcome to fork it and give it a go.

jonathanong commented 8 years ago

give me access then. i don't have time to maintain a fork. i promise not to make breaking changes :)

ninjasort commented 8 years ago

dude, honestly feel free to take the repo. I suck at life.

jonathanong commented 8 years ago

published this as https://www.npmjs.com/package/@jongleberry/react-star-rating

jonathanong commented 8 years ago

oh my god i'm a contributor. i didn't even know. pushing it here! haha

jonathanong commented 8 years ago

@cameronroe can you add me to the npm repo? npm owner add jongleberry react-star-rating. thanks!

ninjasort commented 8 years ago

So I didn't say you could take the package.

jonathanong commented 8 years ago

https://github.com/cameronroe/react-star-rating/commit/35d24f57ffbb3d14d6b587800af7fc6fd622a1bc