search

ninjasort / react-star-rating

[Looking for Maintainers (email me)]: A simple star rating component built with React.
MIT License
173 stars 55 forks source link

Update to allow for editing to still occur if a rating prop is passed… #8

Closed ge3kusa closed 9 years ago

ge3kusa commented 9 years ago

… in to enable behavior similar to 'defaultValue'. Requires editing prop to be passed in as true or it defaults to its previous behavior. #7

ninjasort commented 9 years ago

Great, thanks. :+1:

jesse-wang commented 9 years ago

Is this fixed now?

I'm using 1.3.2, still, when the editing prop is set to true, and a rating prop is also set, it is not editable.

ge3kusa commented 9 years ago

I might be wrong about this but I don't think the changes were ever pushed to NPM. But if you instead specify the git url for this project in your package.json file it might pull in the changes you need.

On Tue, Oct 6, 2015 at 10:00 PM Jesse Wang notifications@github.com wrote:

Is this fixed now?

I'm using 1.3.2, still, when the editing prop is set to true, and a rating prop is also set, it is not editable.

— Reply to this email directly or view it on GitHub https://github.com/cameronjroe/react-star-rating/pull/8#issuecomment-146064671 .