search

ninjasource / embedded-bacnet

A library to read and write bacnet packets for embedded devices
Apache License 2.0
12 stars 2 forks source link

Fix decoding ReadPropertyMultipleAck + add more ReadRangeValueTypes #6

Open mnbbrown opened 2 months ago

mnbbrown commented 2 months ago

~ReadPropertyMultipleAck::new_from_buf doesn't take a reader, so it will attempt to decode from the beginning of the slice. This fixes it to only pass the remaining buf.~ (you beat me too it)

Add more support for decoding ReadRangeValueType (bool, unsigned, signed and NULL).

ninjasource commented 2 months ago

I don't think it's a good time to add anything right now or you're going to have some painful merge conflicts to resolve. I'm busy making significant changes to solve these ownership issues.

ninjasource commented 1 month ago

Ok the major refactor is done for now. I'm not 100% happy with it (ideally I would like to get rid of all the lifetimes if the alloc feature is enabled but that would involve writing another macro and I need to think about weather or not it makes things better or worse (more obscure).