search

ninjasource / embedded-websocket

A rust websocket library for embedded systems (no_std)
Apache License 2.0
98 stars 28 forks source link

Update example server.rs #9

Closed nworbnhoj closed 2 years ago

nworbnhoj commented 2 years ago

minimal changes to compile

ninjasource commented 2 years ago

Hi, thanks for your interest in the project! I'm just trying to understand your change though because there are currently no issues with compilation. The server.rs is meant to be paired with the example client but it looks like you may have attempted to turn it into something more general purpose which is not really the intention behind it. For example I really do want the server to exit out of its loop if it does not receive a text message from the client but you have changed that logic to simply continue the loop and ignore the message.

nworbnhoj commented 2 years ago

You are quite right. I dropped this example into my fork of xous to act as a simple local test for a client built with embedded-websocket. I was surprised when it did not compile - fixed the errors - and offered the PR here without checking the changes in its original context. my bad.

ninjasource commented 2 years ago

If you don't mind I'm going to close this PR as per the comments above.