search

ninjatronic / angular-base64

Base64 conversion for AngularJS
Other
186 stars 113 forks source link

Use dash casing #1

Closed kenhkan closed 10 years ago

kenhkan commented 10 years ago

Is it possible to rename this to ng-base64? Somehow Bower is using a lower case version of the library when it's used indirectly. I have an app using angular-kinvey, which uses this and it returns a NO_BOWER_JSON error showing that it's expecting ngbase64 rather than ngBase64. It's not a problem for me as I use a Mac with case insensitive HFS but a colleague of mine encountered this problem because he's on a linux box. Or is there a solution to this problem? Thanks.

ninjatronic commented 10 years ago

I think this might fix it, but it's still undeployed: https://github.com/bower/registry/issues/15

I've been wondering about changing the name of this package, as angular prefers you not to use 'ng'. I'll post back with progress.

kenhkan commented 10 years ago

Great! Thank you @ninjatronic. Right now we're just declaring ngBase64 directly in the project's bower.json. That seems to solve it, though a long-term fix would be good.

p.s. Good call on 'ng' too. I'll change my Angular repos to be prefixed with angular- instead.

ninjatronic commented 10 years ago

Apologies for the delay on this one. The package is renamed now. There is a corresponding issue on the Kinvey repo: https://github.com/ninjatronic/angular-kinvey/issues/14