removed all references to 'this'.

ninjatronic / angular-base64

Base64 conversion for AngularJS

Other

186 stars 113 forks source link

removed all references to 'this'. #3

Closed boxxxie closed 10 years ago

boxxxie commented 10 years ago

https://github.com/ninjatronic/angular-base64/issues/2 returning object of 2 functions only. helper functions are now nested (no duplicate functions needed) helper constants ALPHA and PADCHAR are duplicated in the 2 returned functions.

ninjatronic commented 10 years ago

Hi @boxxxie

I'm rejecting this pull request because of the duplication caused by nesting the ALPHA and PADCHAR constants, and the getByte64 function.