ninject / Ninject.Web.Mvc

extension for ninject providing integration with ASP.NET MVC
http://ninject.org/
Other
238 stars 85 forks source link

Please Update Web Activator Dependency #29

Closed LorenDorez closed 11 years ago

LorenDorez commented 11 years ago

Hi I have been working with the creator of WebActivator closely for a new issue that arose with update to .net 4.5 using MVC. We have patched a work around in WebActivator 2.0.2, but ninject this requires 1.5.x

Can you please update ninject to use the latest WebActivator

remogloor commented 11 years ago

Implemented in https://github.com/ninject/Ninject.Web.Common/commit/55829c27699e434fcaa1168514b1cce0f8241f03

johanncampbell commented 11 years ago

Seems that there are still issues resolving WebActivator. I think it should be looking for WebActivatorEx (for Ninject.MVC3 3.0.2-unstable 8 on Nuget).

lstyles commented 10 years ago

Not only it should be using WebActivatorEx package instead. It should also use:

[assembly: WebActivatorEx.PreApplicationStartMethod(typeof(WebApplication1.Web.AppStart), "Start")] [assembly: WebActivatorEx.ApplicationShutdownMethodAttribute(typeof(WebApplication1.Web.AppStart), "Stop")]

in NinjectWebCommon.cs that's automatically added.

Please update.

danielmarbach commented 10 years ago

How about sending a pull?

Am 06.01.2014 um 04:10 schrieb lpaluszk notifications@github.com:

Not only it should be using WebActivatorEx package instead. It should also use:

[assembly: WebActivatorEx.PreApplicationStartMethod(typeof(VoiceVue.Web.AppStart), "Start")] [assembly: WebActivatorEx.ApplicationShutdownMethodAttribute(typeof(VoiceVue.Web.AppStart), "Stop")]

in NinjectWebCommon.cs that's automatically added.

Please update.

— Reply to this email directly or view it on GitHub.

lstyles commented 10 years ago

The old WebActivator reference comes from Ninject.Web.Common and not this repo. Apologies.