search

ninjudd / cake

A tasty build tool for Clojure.
clojure-cake.org
Eclipse Public License 1.0
171 stars 12 forks source link

Cake packages :exclusions when using cake install #114

Closed sritchie closed 13 years ago

sritchie commented 13 years ago

Hey all,

I'm currently working on releasing pallet-hadoop to clojars -- the project imports pallet with a number of exclusions to allow for the use of jclouds-9b. (Here's the project file.)

When I run cake deps, I can head into pallet-hadoop/lib and verify that, indeed, all of those files have been excluded. When I:

  1. run cake install
  2. include the project in another project with :dev-dependencies [[pallet-hadoop "0.0.2-SNAPSHOT"]]
  3. run cake deps force on that project

I see that a whole bunch of jclouds-*-beta-8.jar have been included, in addition to the jclouds 9b files.

To verify that these files weren't getting pulled in from some other dependency, I tried installing with leiningen (lein install, and cake deps force on the other project) and found that these extra files don't get included.

I'm currently using cake 0.6.2.

davidsantiago commented 13 years ago

Hm, I really don't understand how maven poms and Ant and exclusions and all that stuff work. At all. But it looks to me like the logic for deps, in src/cake/tasks/deps.clj, is a lot more detailed and nuanced with respect to things like Poms and Exclusions, than the install task, at the end of src/cake/tasks/jar.clj. Is it possible that the 2-line install task is just taking an easy route to generate the pom when really it should be using code that exists in deps.clj?

On Sat, May 28, 2011 at 1:58 PM, sritchie reply@reply.github.com wrote:

Hey all,

I'm currently working on releasing pallet-hadoop to clojars -- the project imports pallet with a number of exclusions to allow for the use of jclouds-9b. (Here's the project file.)

When I run cake deps, I can head into pallet-hadoop/lib and verify that, indeed, all of those files have been excluded. When I:

  1. run cake install
  2. include the project in another project with :dev-dependencies [[pallet-hadoop "0.0.2-SNAPSHOT"]]
  3. run cake deps force on that project

I see that a whole bunch of jclouds-*-beta-8.jar have been included, in addition to the jclouds 9b files.

To verify that these files weren't getting pulled in from some other dependency, I tried installing with leiningen (lein install, and cake deps force on the other project) and found that these extra files don't get included.

I'm currently using cake 0.6.2.

Reply to this email directly or view it on GitHub: https://github.com/ninjudd/cake/issues/114

ninjudd commented 13 years ago

it looks to me like we are not including exclusions in the pom. we should be looking for exclusions in cake.tasks.deps/prxml-tags. should be an easy fix. @lancepantz, can you take a look at this when you get a few minutes?