Closed Moocar closed 12 years ago
@Raynes, can you take a look at these when you get some time?
On Jun 19, 2012, at 3:20 PM, Anthony Marcar wrote:
Upgraded to Clojure 1.3.0 Made compatible with Lein2
You can merge this Pull Request by running:
git pull https://github.com/Moocar/clojure-protobuf develop
Or you can view, comment on it, or merge it online at:
https://github.com/flatland/clojure-protobuf/pull/29
-- Commit Summary --
- upgraded to be compatible with lein2
- upgraded to clojure 1.3.0 and changed Exceptions to RuntimeExceptions in assocEx and without methods
-- File Changes --
M .gitignore (1) M project.clj (4) M src/leiningen/protobuf.clj (4) M src/protobuf/core/PersistentProtocolBufferMap.java (8)
-- Patch Links --
https://github.com/flatland/clojure-protobuf/pull/29.patch https://github.com/flatland/clojure-protobuf/pull/29.diff
Reply to this email directly or view it on GitHub: https://github.com/flatland/clojure-protobuf/pull/29
@ninjudd I'll test asap, but his lein changes look fine. You'll have to take a look though because he changed some stuff in the protobuf code that I have utterly zero understanding of.
This is excellent though. I can finally move Jiraph to lein 2 when this is merged. @amalloy will be pleased.
Yeah, it appears that in Clojure 1.3, "without" and "assocEx" don't through checked exceptions anymore, so I just replaced it with a RuntimeException. I also have zero understanding of the inner protobuf java code. Gets the "Works on my machine" stamp atleast :)
Merged this in and fixed some issues, etc. Thanks!
Upgraded to Clojure 1.3.0 Made compatible with Lein2