Removed flatland/io require from protobuf codec

ninjudd / clojure-protobuf

Google protocol buffers wrapper for Clojure.

Eclipse Public License 1.0

217 stars 70 forks source link

Removed flatland/io require from protobuf codec #40

Closed orva closed 11 years ago

orva commented 11 years ago

It seems to be unused and causes runtime errors when using codec as flatland/io is only dev-dependency in this project.

amalloy commented 11 years ago

No good: we don't need any functions from flatland/io, but we do need to load it because it extends one of the protocols in clojure.java.io so that we can create an InputStream from a sequence of ByteBuffers. It seems to me like the right fix for this issue would be to (1) make flatland/io a regular dependency, and (2) add a comment explaining why we're requiring. If you send a pull request for that I'd be happy to merge and release it.

orva commented 11 years ago

Ah, of course. Should have actually thought about this and not just skim through and run tests.