ninjudd / memcache

Advanced ruby memcache client
MIT License
47 stars 23 forks source link

OS X extension fix #22

Closed chrisjwu closed 10 years ago

chrisjwu commented 10 years ago

I added dynamic extension lookup for the libmemcached shared libraries.

I was unable to test if it was correct to also do that for the amd64 architecture, but I assume it's fine.

ninjudd commented 10 years ago

iOS?

On Mon, Feb 10, 2014 at 11:02 AM, chrisjwu notifications@github.com wrote:

I added dynamic extension lookup for the libmemcached shared libraries. I was unable to test if it was correct to also do that for the amd64 architecture, but I assume it's fine. You can merge this Pull Request by running: git pull https://github.com/chrisjwu/memcache master Or you can view, comment on it, or merge it online at: https://github.com/ninjudd/memcache/pull/22 -- Commit Summary --

chrisjwu commented 10 years ago

Er, I mean OS X, fixed the title.

ninjudd commented 10 years ago

Looks good to me. @chrisjwu, would you mind separating the duplication out into a function before I merge the pull request?

chrisjwu commented 10 years ago

Done