ninoxconsulting / PEMr

Machine Learning Predictive Ecosystems Mapping (MLPEM)
Apache License 2.0
0 stars 0 forks source link

update core files to qmd - which files are needed in qmd template #3

Open gcperk opened 1 month ago

gcperk commented 1 month ago

Updated .qmd base file although not sure if we need to also add the accompanying (folder, ie css details). This is currently causing an issue with the write_core_files as the qmd creates a folder.

I added a temporary fix with the file type filter and kept the .R file in also. Requires update on tests once completed

ateucher commented 1 month ago

We should only be committing the .qmd and/or .R files in the template directory, and really never rendering those directly (except perhaps on rare occasions for interactive experimenting), so that detritus shouldn't end up in there. We could add a .gitignore to ignore everything but .qmd and .R files, but it's important to think of the templates directory (and the package structure as a whole) as the source of files that the user will work on, and not a place that the user (or us as we develop the package) to actually do the work

gcperk commented 1 month ago

@ateucher thanks for the input on this. I rendered locally but my spiney senses went off for committing these file so I only have them locally. I think we will ditch .qmd anyway so I can revert back to original format with .R as template directory files. I will keep this open until confirmed .