search

ninsuo / symfony-collection

[NOT MAINTAINED] A jQuery plugin that manages adding, deleting and moving elements from a Symfony form collection
https://symfony-collection.fuz.org/
MIT License
444 stars 88 forks source link

Issue with Bootstrap 4 form themes #105

Open ghost opened 6 years ago

ghost commented 6 years ago

Hi there,

I upgraded to Symfony 3.4 today which includes support for the new version of bootstrap 4 form themes as shown here: https://symfony.com/blog/new-in-symfony-3-4-bootstrap-4-form-theme

So I upgraded my assets to bootstrap 4 and the form-collection was still working fine. However, when I updated in my config for it to use bootstrap 4 form themes as explained in the link above, none of the form collections work correctly anymore. Some of my forms had limits on which no longer work and you can not change the order or remove forms from the collection.

Will support be added for this soon?

Thanks

ninsuo commented 6 years ago

Sure, thank you for your report, will have a look this week end. Alain

ninsuo commented 6 years ago

Hi there,

I spent almost 10 hours on this plugin today to fix #98, I'm going to move to other projects.

Will check your issue within the 2 next weeks.

Please, have a look to elements_selector and elements_parent_selector options ; if the new bootstrap form theme has another markup (like more nested divs etc), it could explain why nothing works anymore.

If you find the solution, please share it ;)

Have a good weekend,

Alain

jayesbe commented 6 years ago

@DBarkz did you come up with a solution for bootstrap 4 ?

jayesbe commented 6 years ago

@ninsuo for bootstrap 4 

elements_selector: '> fieldset'
ninsuo commented 6 years ago

Thank you very much for sharing. A

migo315 commented 6 years ago

@jayesbe Thanks. Got the same error and that solve it.