search

nint22 / dwarfcraft

Automatically exported from code.google.com/p/dwarfcraft
Other
0 stars 0 forks source link

Designations should never be deleted until all assigned jobs are completed #191

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Designations can have all target blocks given out, and will self-delete, even 
though dwarves may return these back. We need a ref-counter in each designation 
to make sure it never releases while jobs are still out, even if the active 
list is empty.

Original issue reported on code.google.com by nin...@gmail.com on 14 Mar 2012 at 10:52

GoogleCodeExporter commented 9 years ago 
Fixed

Original comment by nin...@gmail.com on 14 Mar 2012 at 11:28

GoogleCodeExporter commented 9 years ago 
Reopening - did not fix

Original comment by nin...@gmail.com on 14 Mar 2012 at 11:32

GoogleCodeExporter commented 9 years ago 
Design issue: Just check if there are <= 0 jobs rather than just == 0, just for 
the sake of better error-handling behavior

Core issue: some tasks may disappear on their own because of another task 
overriding it (think of two designations intersecting). Thus, when resigning a 
job, we should check if this job should even exist anymore...

Original comment by nin...@gmail.com on 14 Mar 2012 at 11:52