Closed GoogleCodeExporter closed 9 years ago
Hi Milton,
Thanks for the patch. This is the right process, just file an issue here in the
CLD2 project and attach a patch file like you did. We'll take a look and get
back to you.
Looks straightforward, I think the primary concern will be testing it on some
real producion ARM v8-a hardware so that we can verify that the instruction
alignment stuff (and so on) works properly there and doesn't crash.
Jason Riesa (riesa@google.com, cc'd) is the current maintainer of the overall
project, I usually handle stuff for dynamic data loading and Chromium
integration.
Original comment by andrewha...@google.com
on 5 May 2015 at 9:50
This looks fine to me. Who can test it on an ARM v8 chip? /dick
Original comment by dsi...@google.com
on 5 May 2015 at 10:07
@#2 Milton can test on his ARMv8-A chip. And/or I can help route ARMv8-A
hardware to whomever would like to verify.
Original comment by djku...@chromium.org
on 12 May 2015 at 2:28
I have tested it on our ARMv8-A platform with "armv7a-cros-linux-gnueabi-gcc
-march=armv8-a+crc" and every thing works fine to me.
Original comment by milton.c...@gmail.com
on 27 May 2015 at 12:45
Committed as r195. Thanks!
Original comment by andrewha...@google.com
on 27 May 2015 at 7:40
Original issue reported on code.google.com by
andrewha...@google.com
on 5 May 2015 at 9:46Attachments: