search

niolabs / python-xbee

Python tools for working with XBee radios
MIT License
101 stars 45 forks source link

Removed \x90 rx.frame_id, added one byte to rx.source_address length #41

Closed BenTheNinjaRock closed 7 years ago

BenTheNinjaRock commented 7 years ago

\x90 has no frame_id as far as I can tell

jamesleesaunders commented 7 years ago

Hi Ben, Thanks for contributing! Looking at the 'Receive Packet Frame 0x90' spec at https://www.digi.com/resources/documentation/digidocs/pdfs/90000991.pdf (Page 133) it looks like you are right:

Frame data fields Offset Description Frame type 3 0x90 64-bit source address 4-11 The sender's 64-bit address. MSB first, LSB last. Reserved 12-13 Reserved. Receive options 14 Bit field: 0x01/0x02. Received data 15-n The RF data the device receives.

I have no way to test this but @luk156 and @thom-nic are the original contributors of the DigiMesh class I don't know if they have any other comments? But all looks good to me, I will leave it to the guys nioinnovation to give the final PR approval.

BenTheNinjaRock commented 7 years ago

No problem, glad to hear you agree! I've been using the altered code for a while and seems to work fine, but did want to check just to make sure.

thom-nic commented 7 years ago

LGTM