search

niolabs / python-xbee

Python tools for working with XBee radios
MIT License
101 stars 45 forks source link

Digimesh Library default values should be bytes #45

Closed killian441 closed 7 years ago

killian441 commented 7 years ago

For Python3 the digimesh module fails if given the defaults because they are currently strings and not bytes.

jamesleesaunders commented 7 years ago

Hi @killian441 thanks for raising. Please do feel to fork/raise pull request if you have a proposed fix. Contributions are always welcome :-)

jamesleesaunders commented 7 years ago

I have added Python 3 support to the DigiMesh class on PR #46. Feel free to give it a test by cloning this branch while we wait for it to be approved to be merged with master: https://github.com/nioinnovation/python-xbee/tree/issue45-digimesh-p3

killian441 commented 7 years ago

Hi, thanks for putting together a pull-request. I had planned to do one when I had some free time, but this is all I would do. Looks good

jamesleesaunders commented 7 years ago

No problem., this was a fairly simple one :-). Please do feel free to contribute if you see anything else amiss. This has now been merged in DigiMesh should now work with Python 3. Jim