search

nion-software / eels-analysis

A Nion Swift package for doing EELS analysis.
GNU General Public License v3.0
6 stars 9 forks source link

EELS -> Subtract Background from Spectrum only works when an interval graphic already exists in the selected data item #16

Open Brow71189 opened 5 years ago

Brow71189 commented 5 years ago

This occurs with swift 0.13.9 (developer installation) To reproduce, try to run background subtraction on any 1D data item. Nothing will happen unless there already exists an interval graphic in the data item.

cmeyer commented 5 years ago

Maybe a dialog allowing the user to either choose an edge from the edge table or enter an interval directly should be presented? Otherwise, what do you propose?

Brow71189 commented 5 years ago

I think it could also just create a graphic when none exists and use an existing one if one exists. I just find it confusing when you click on "subtract background" and nothing happens.

On Fri, Dec 28, 2018, 23:50 Chris Meyer <notifications@github.com wrote:

Maybe a dialog allowing the user to either choose an edge from the edge table or enter an interval directly should be presented? Otherwise, what do you propose?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nion-software/eels-analysis/issues/16#issuecomment-450439242, or mute the thread https://github.com/notifications/unsubscribe-auth/AP8lK4QZZ3PZ7pvKfh-da-cJH3fsvnTcks5u9qAegaJpZM4ZFrqJ .