search

nion-software / eels-analysis

A Nion Swift package for doing EELS analysis.
GNU General Public License v3.0
6 stars 9 forks source link

Added computation for aligning sequences of spectrum images. #39

Closed Brow71189 closed 4 years ago

cmeyer commented 4 years ago

I do not think we should be using the computation UI any further. It is likely I'm going to break it soon and we need to replace it with something I can maintain and test.

Brow71189 commented 4 years ago

Can we merge this so that it is available until we have a replacement for the ComputationUI? The computation will still work even if the UI breaks, you will only be stuck with the default parameters.

Chris Meyer notifications@github.com schrieb am Di., 14. Apr. 2020, 20:38:

I do not think we should be using the computation UI any further. It is likely I'm going to break it soon and we need to replace it with something I can maintain and test.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nion-software/eels-analysis/pull/39#issuecomment-613611785, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD7SKK7INWQMNFE6D4GGXK3RMSURHANCNFSM4MHV73EA .

cmeyer commented 4 years ago

Can you put this into experimental for now? I'm not sure this fits into EELS analysis.

cmeyer commented 4 years ago

As more explanation: I don't want EELS analysis to become a catch-all for things that belong elsewhere or things that should have a more general implementation. How is this PR different from what is provided in Swift? Does it really belong in EELS analysis or does it belong somewhere else eventually? If it eventually belongs somewhere else, I think it should go into experimental until the final location is figured out.

Brow71189 commented 4 years ago

Closed because this will go into nion-software/experimental for now