search

nion-software / nionswift-instrumentation-kit

Base classes for Nion Swift STEM microscope instrumentation
GNU General Public License v3.0
1 stars 12 forks source link

"grab_sequence_prepare" is missing call to "acquire_sequence_prepare" #167

Closed Brow71189 closed 6 months ago

Brow71189 commented 9 months ago

This causes camera implementations that rely on this call (for example dectris) to fail when using the "grab_sequence" API functions.

Also it is weird that "grab_sequence_prepare" already calls "acquire_sequence_begin". The expected behavior that the actual acquisition does not start until "grab_sequence" is called, not already during the "prepare" method.

https://github.com/nion-software/nionswift-instrumentation-kit/blob/f9d3dc17c67341b38335a65510a9f0d327f5eb2f/nion/instrumentation/camera_base.py#L2194