nion-software / nionswift-instrumentation-kit

Base classes for Nion Swift STEM microscope instrumentation
GNU General Public License v3.0
1 stars 12 forks source link

Acquisition panel resets all camera frame parameters to defaults #174

Closed Brow71189 closed 6 months ago

Brow71189 commented 6 months ago

I noticed this when trying to use binning with the Acquisition panel. It would always use 1, no matter what I had set the camera binning to before.

I think I tracked it down to this line, which creates CameraFrameParameters from an empty dict, which simply means it creates frame parameters with the default values. Then it puts the exposure time from the acquisition panel in, but all other frame parameters are lost.

https://github.com/nion-software/nionswift-instrumentation-kit/blob/481f4ad7764ad232cc32dccc05a33a31d07b3b3b/nionswift_plugin/nion_instrumentation_ui/AcquisitionPanel.py#L1017