nion-software / nionswift-instrumentation-kit

Base classes for Nion Swift STEM microscope instrumentation
GNU General Public License v3.0
1 stars 12 forks source link

Acquisition pipeline for sequence of spectra reverts to single-frame fallback #92

Closed cmeyer closed 2 years ago

cmeyer commented 2 years ago

This is because the 'wrap' function does not work on the 'FramedDataStream' that is used when acquiring spectra.

bentps commented 2 years ago

Just a comment on this: it seems to me that fallback to series of single-frame acquisition if something goes wrong with the sequence acquire is worse than visibly failing with an error message. From the user perspective, a series of single frame images that takes 1000 times as long as the expected sequence is as bad or worse than a failure (in that it can take a lot of time and then return something not wanted), so it often isn't helpful to silently do that behavior. Anyway, hopefully the sequence stuff just works in the future, but I'd non-urgently suggest not having this fallback available if it ever fails.