nion-software / nionswift

Nion Swift is open source scientific image processing software integrating hardware control, data acquisition, visualization, processing, and analysis using Python. Nion Swift is easily extended using Python. It runs on Windows, Linux, and macOS.
http://nion.com/swift
GNU General Public License v3.0
44 stars 33 forks source link

Minor cleanup to export dialog #1068

Open cmeyer opened 3 months ago

cmeyer commented 3 months ago

More items to-do (after merge):

### Tasks
- [ ] Elide the directory string to fit to width. the UserInterface.py truncate_string_to_width may be helpful.
- [ ] Clean up the prefix string to auto-enable if user enters prefix string
- [ ] Save the export options from viewmodel. the UserInterface.StringPersistentModel and similar classes may be helpful here.
bentps commented 2 months ago

Is this the right place to comment on the (generally excellent) recent changes to the export dialog?

There are 4 checkboxes for what info to include in the file name. In the previous version, the state of the checkboxes was remembered from one use of the dialog to the next. Now, all four checkboxes are checked each time the dialog is opened. I much prefer the previous behavior.

As an aside, I only ever use the "include title" box. The other ones seem unnecesary to me, but I don't know if anyone else uses them.

cmeyer commented 2 months ago

Yes, this is a good place to make minor comments. If something is more significant or you want it tracked separately, you can also file a separate issue and I will link it from here depending on its significance.

The "remember the choices" item is already listed above as the 3rd task. I reworded it to make it more evident.

It's difficult to know what people use; maybe users can comment if they're following this issue. Otherwise, I don't like to remove functionality. I think remembering the options will go a long way towards addressing the "some people may find some options extraneous" issue.