Export results tabulated in popup

nion-software / nionswift

Nion Swift is open source scientific image processing software integrating hardware control, data acquisition, visualization, processing, and analysis using Python. Nion Swift is easily extended using Python. It runs on Windows, Linux, and macOS.

http://nion.com/swift

GNU General Public License v3.0

43 stars 33 forks source link

Export results tabulated in popup #1072

Closed KRLango closed 1 week ago

KRLango commented 1 week ago

This is for issue https://github.com/nion-software/nionswift/issues/749. It presents the results of exports in a popup showing which succeeded and which failed. For failed exports any error message is shown.

An option to open the folder where the exports are saved is also included for quickly getting to the outputs.

Ion-e commented 1 week ago

Bug - Attempting to export an invalid export is reported as "success" in the dialog, however the export doesn't complete, please also note that there are no error messages thrown on the Outputs when the export fails.

Please also note that there no error messages thrown on the Outputs when the export succeeds, is this something we would want? @cmeyer

cmeyer commented 1 week ago

Merged with changes.json, squashed, minor edit to commit message 899098e4456dd27aac4692b184274c06b433ba5e

Notes and future work:

You can get the UserInterface ui object using document_controller.ui. This fact isn't always used consistently in existing code...
Another note: document_controller is basically the window. It is named "controller" due to historical reasons.
The results dialog should probably be cleaned up to be centered after display (not sure how to do this, may need to measure outputs before-hand and estimate width).
The results dialog should also probably include a scroll area in case there are 100 output items to report.
An additional task is to move the "open file in explorer" code to Utility.py so it is common. It occurs in 3+ places right now.
I didn't add new issues for any of the "to-do" style items above.

cmeyer commented 1 week ago

Bug - Attempting to export an invalid export is reported as "success" in the dialog, however the export doesn't complete, please also note that there are no error messages thrown on the Outputs when the export fails.

Please also note that there no error messages thrown on the Outputs when the export succeeds, is this something we would want? @cmeyer

The Output window is used inconsistently right now - so I'd say let's not worry about it for now until we have a consistent story for the Output window.