Logic for creation of keybind cheat sheet window

lisham2000 commented 2 months ago

Construction of HTML key-bind cheat-sheet window

lisham2000 commented 2 months ago

PR in combination with #1139 of nionswift

cmeyer commented 2 months ago

I'm going to reject this PR. Instead, let's start with something in nionswift. Also, we should have something that is done directly in the UI and doesn't use an external web browser. That gives us room to expand it's capabilities if needed.

A few comments about this PR anyway, even though rejected:

it breaks encapsulation (nionui should not know about Swift) os.path.join(current_dir, "..", "..", "..", "nionswift", "nion", "swift", "resources", "key_config.json")
directory layouts between packages aren't guaranteed, so no assumptions should be made about them
resources should be accessed through the package (see this link)
How about just calling it "Shortcuts" in both the UI and code?

I'll add some notes to the original issue nion-software/nionswift#1139 with additional suggestions on how to go about this task.

nion-software / nionui

Logic for creation of keybind cheat sheet window #80