search

niosh-mining / obsplus

A Pandas-Centric ObsPy Expansion Pack
GNU Lesser General Public License v3.0
38 stars 8 forks source link

fix duplicate channel issue on df_to_inventory #190

Closed d-chambers closed 4 years ago

d-chambers commented 4 years ago

Fixes issue with duplicate channels setting incorrect start_dates on station level (#188)

codecov-commenter commented 4 years ago

Codecov Report

Merging #190 into master will increase coverage by 0.12%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
+ Coverage   97.23%   97.35%   +0.12%     
==========================================
  Files          37       37              
  Lines        4159     4159              
  Branches      661      659       -2     
==========================================
+ Hits         4044     4049       +5     
+ Misses         54       52       -2     
+ Partials       61       58       -3
Flag Coverage Δ
#unittests 97.35% <100.00%> (+0.12%) :arrow_up:
Impacted Files Coverage Δ
obsplus/utils/misc.py 98.26% <ø> (-0.09%) :arrow_down:
obsplus/utils/stations.py 99.47% <100.00%> (+2.82%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e44b1f5...d8c0784. Read the comment docs.

sboltz commented 4 years ago

I think this looks good. Addresses #188