search

niosh-mining / obsplus

A Pandas-Centric ObsPy Expansion Pack
GNU Lesser General Public License v3.0
38 stars 8 forks source link

leouieda pre review #194

Closed d-chambers closed 4 years ago

d-chambers commented 4 years ago

This PR address some of the review points offered by leouieda here. It also adds pre-commit, some simple pre-commit hooks, and updates the documentation accordingly.

codecov-commenter commented 4 years ago

Codecov Report

Merging #194 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #194   +/-   ##
=======================================
  Coverage   97.35%   97.35%           
=======================================
  Files          37       37           
  Lines        4166     4166           
  Branches      662      662           
=======================================
  Hits         4056     4056           
  Misses         52       52           
  Partials       58       58
Flag Coverage Δ
#unittests 97.35% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
obsplus/datasets/dataset.py 98.23% <100.00%> (ø)
obsplus/utils/stations.py 99.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dfcbb6d...5a1c41c. Read the comment docs.

sboltz commented 4 years ago

@d-chambers Just a heads up, it appears that whatever you were working on last night took out the docs.

d-chambers commented 4 years ago

Ok thanks @sboltz, I got it fixed.