niosh-mining / obsplus

A Pandas-Centric ObsPy Expansion Pack
GNU Lesser General Public License v3.0
38 stars 8 forks source link

Reject old data rather than delete it on event merging #209

Closed sboltz closed 4 years ago

sboltz commented 4 years ago

This pull request changes obsplus.utils.events.merge_events and obsplus.utils.events.associate_merge by replacing the logic to delete old data (picks and amplitudes) with logic to instead reject old data.

codecov-io commented 4 years ago

Codecov Report

Merging #209 (56c674e) into master (e8fd34c) will decrease coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
- Coverage   97.45%   97.43%   -0.02%     
==========================================
  Files          37       37              
  Lines        4276     4284       +8     
  Branches      670      670              
==========================================
+ Hits         4167     4174       +7     
  Misses         52       52              
- Partials       57       58       +1     
Flag Coverage Δ
unittests 97.43% <100.00%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
obsplus/events/merge.py 96.94% <100.00%> (-0.62%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e8fd34c...56c674e. Read the comment docs.