niosh-mining / obsplus

A Pandas-Centric ObsPy Expansion Pack
GNU Lesser General Public License v3.0
38 stars 8 forks source link

Bank raise on unsupported kwargs #214

Closed d-chambers closed 3 years ago

d-chambers commented 3 years ago

This PR ensures both EventBank and WaveBank raise a newly defined UnsupportedKerword exception when, well, an unsupported keyword is used.

Addresses #207

codecov-io commented 3 years ago

Codecov Report

Merging #214 (e6d647d) into master (9697c5d) will decrease coverage by 0.00%. The diff coverage is 98.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
- Coverage   97.43%   97.43%   -0.01%     
==========================================
  Files          37       37              
  Lines        4284     4320      +36     
  Branches      670      677       +7     
==========================================
+ Hits         4174     4209      +35     
  Misses         52       52              
- Partials       58       59       +1     
Flag Coverage Δ
unittests 97.43% <98.03%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
obsplus/bank/wavebank.py 97.08% <ø> (-0.05%) :arrow_down:
obsplus/utils/bank.py 95.85% <95.00%> (-0.17%) :arrow_down:
obsplus/bank/eventbank.py 99.54% <100.00%> (+<0.01%) :arrow_up:
obsplus/constants.py 100.00% <100.00%> (ø)
obsplus/events/get_events.py 95.37% <100.00%> (+0.52%) :arrow_up:
obsplus/exceptions.py 100.00% <100.00%> (ø)
obsplus/utils/misc.py 98.32% <100.00%> (+0.05%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9697c5d...e6d647d. Read the comment docs.

d-chambers commented 3 years ago

@sboltz mind giving this a quick look-over? The changes in codecov come from deleting code that was run but wasn't actually doing anything.