d-chambers commented 3 years ago

I got frustrated that get_waveforms_bulk didn't accept a DataFrame so now it does (provided it has columns: network, station, location, channel, starttime, endtime).

I also found some parts of the code that were near duplicates between obsplus.waveforms.get_waveforms_bulk, which acts on obspy.Stream instances, and obsplus.WaveBank.get_waveforms_bulk so I cleaned that up too.

d-chambers commented 3 years ago

This is mainly an internal refactoring but if someone wants to review it I will leave this PR open for a few days then merge.

codecov-io commented 3 years ago

Codecov Report

Merging #229 (e14aa53) into master (aa6dcb9) will increase coverage by 0.02%. The diff coverage is 98.26%.

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
+ Coverage   97.85%   97.87%   +0.02%     
==========================================
  Files          39       39              
  Lines        4616     4618       +2     
  Branches      661      661              
==========================================
+ Hits         4517     4520       +3     
+ Misses         44       42       -2     
- Partials       55       56       +1

Flag	Coverage Δ
unittests	`97.87% <98.26%> (+0.02%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
obsplus/bank/wavebank.py	`97.24% <92.00%> (+0.16%)`	:arrow_up:
obsplus/constants.py	`100.00% <100.00%> (ø)`
obsplus/utils/misc.py	`98.35% <100.00%> (+0.02%)`	:arrow_up:
obsplus/utils/waveforms.py	`98.13% <100.00%> (+0.36%)`	:arrow_up:
obsplus/waveforms/get_waveforms.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aa6dcb9...e14aa53. Read the comment docs.

niosh-mining / obsplus

refactor get_waveforms_bulk #229

Codecov Report