search

niosh-mining / obsplus

A Pandas-Centric ObsPy Expansion Pack
GNU Lesser General Public License v3.0
38 stars 8 forks source link

put_waveforms with gaps #232

Closed d-chambers closed 3 years ago

d-chambers commented 3 years ago

Using WaveBank's put_waveforms could previously raise an error related to masked arrays if the waveforms had gaps and used masked arrays. This PR adds a fix (and test) to remedy the problem.

codecov-io commented 3 years ago

Codecov Report

Merging #232 (7bb4255) into master (f21f951) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #232   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files          39       39           
  Lines        4618     4618           
  Branches      661      661           
=======================================
  Hits         4521     4521           
  Misses         42       42           
  Partials       55       55
Flag Coverage Δ
unittests 97.89% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
obsplus/bank/wavebank.py 97.24% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f21f951...7bb4255. Read the comment docs.

d-chambers commented 3 years ago

I accidentally included these commits in another PR. No big deal since these tests are all green and I was going to merge anyway. Closing.