search

niosh-mining / obsplus

A Pandas-Centric ObsPy Expansion Pack
GNU Lesser General Public License v3.0
38 stars 8 forks source link

bump python versions #247

Closed d-chambers closed 3 years ago

d-chambers commented 3 years ago

This PR bumps the supported python versions from 3.6-3.8 to 3.8-3.9.

codecov-commenter commented 3 years ago

Codecov Report

Merging #247 (e906665) into master (57ccedc) will decrease coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
- Coverage   97.90%   97.88%   -0.03%     
==========================================
  Files          39       39              
  Lines        4637     4638       +1     
  Branches      663      663              
==========================================
  Hits         4540     4540              
  Misses         42       42              
- Partials       55       56       +1
Flag Coverage Δ
unittests 97.88% <100.00%> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
obsplus/events/validate.py 94.83% <100.00%> (+0.03%) :arrow_up:
obsplus/events/merge.py 98.47% <0.00%> (-0.77%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 57ccedc...e906665. Read the comment docs.

d-chambers commented 3 years ago

Looks like there are no issues supporting 3.9, which we should probably do since 3.10 is not out 😝. Anyone see any issues with dropping 3.6, adding 3.9 and making a new minor version release?

shawnboltz commented 3 years ago

@d-chambers Makes sense to me. Just to double-check, are you only dropping 3.6 or are you also dropping 3.7? (your initial post says 3.8-3.9)

d-chambers commented 3 years ago

Ya, you are right. It should support 3.7-3.9, sorry for the typo.