Closed d-chambers closed 2 years ago
I guess since we aren't testing python 3.7 we ought to drop support for it (it goes EOL in about a year anyhow). Anyone care if we drop python 3.7 support in the next release?
This works for me, I think. I still have one or two setups that are using 3.7, but that's more out of laziness than an actual need.
I was thinking specifically about @calum-chamberlain for RT_eqcorrscan as I know you had recently updated most the NIOSH systems. On second thought though, we should probably just support 3.7 until its EoL so we don't force any packages using obsplus to upgrade before they are ready. Maybe we just test 3.7/Ubuntu to keep the test matrix small(ish).
Now to figure out how to get the windows 3.10 conda env to work...
Merging #252 (c8108dd) into master (d5b2e46) will increase coverage by
0.13%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #252 +/- ##
==========================================
+ Coverage 97.80% 97.93% +0.13%
==========================================
Files 39 39
Lines 4642 4648 +6
Branches 665 665
==========================================
+ Hits 4540 4552 +12
+ Misses 44 42 -2
+ Partials 58 54 -4
Flag | Coverage Δ | |
---|---|---|
unittests | 97.93% <100.00%> (+0.13%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
obsplus/bank/eventbank.py | 99.54% <100.00%> (ø) |
|
obsplus/bank/wavebank.py | 97.26% <100.00%> (+0.78%) |
:arrow_up: |
obsplus/structures/fetcher.py | 98.62% <100.00%> (+<0.01%) |
:arrow_up: |
obsplus/utils/mseed.py | 90.90% <100.00%> (+0.16%) |
:arrow_up: |
obsplus/utils/stations.py | 99.48% <100.00%> (+0.52%) |
:arrow_up: |
obsplus/events/schema.py | 100.00% <0.00%> (ø) |
|
obsplus/events/merge.py | 99.23% <0.00%> (+0.76%) |
:arrow_up: |
obsplus/events/validate.py | 94.90% <0.00%> (+1.27%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d5b2e46...c8108dd. Read the comment docs.
This PR fixes issue #249 #251, fixes a bunch of warnings, and adds python 10 to the test matrix while eliminating python 3.7.