niosh-mining / obsplus

A Pandas-Centric ObsPy Expansion Pack
GNU Lesser General Public License v3.0
38 stars 8 forks source link

Fix bug where passing 'min_gap' to raises an exception #261

Closed shawnboltz closed 1 year ago

shawnboltz commented 1 year ago

Fixes a small bug in WaveBank.get_segments_df.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8e231f4) 96.58% compared to head (ae3589a) 96.58%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #261 +/- ## ======================================= Coverage 96.58% 96.58% ======================================= Files 44 44 Lines 4806 4807 +1 Branches 675 675 ======================================= + Hits 4642 4643 +1 Misses 108 108 Partials 56 56 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `96.58% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=niosh-mining#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/niosh-mining/obsplus/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=niosh-mining) | Coverage Δ | | |---|---|---| | [src/obsplus/bank/wavebank.py](https://codecov.io/gh/niosh-mining/obsplus/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=niosh-mining#diff-c3JjL29ic3BsdXMvYmFuay93YXZlYmFuay5weQ==) | `96.84% <100.00%> (+0.01%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=niosh-mining). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=niosh-mining)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.